Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat(kit): support client and server flags for addVitePlugin - #5560

Merged
pi0 merged 2 commits into
mainfrom
feat/vite-plugin-flags
Jun 22, 2022
Merged

feat(kit): support client and server flags for addVitePlugin#5560
pi0 merged 2 commits into
mainfrom
feat/vite-plugin-flags

Conversation

@danielroe

Copy link
Copy Markdown
Member

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We support client/server flags for addWebpackPlugin; this allows us to do the same for addVitePlugin

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added enhancement New feature or request kit labels Jun 22, 2022
@danielroe
danielroe requested a review from pi0June 22, 2022 09:05
@danielroedanielroe self-assigned this Jun 22, 2022
@netlify

netlifyBot commented Jun 22, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitf2b5d79
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62b2db53f98e750008d6bbb1

@pi0pi0 changed the title feat(kit): support client/server flags for addVitePluginfeat(kit): support client and server flags for addVitePluginJun 22, 2022
pi0
pi0 approved these changes Jun 22, 2022
@pi0
pi0 merged commit 3081489 into mainJun 22, 2022
@pi0
pi0 deleted the feat/vite-plugin-flags branch June 22, 2022 17:29
@pi0

pi0 commented Jun 22, 2022

Copy link
Copy Markdown
Member

Nice addition

@pi0pi0 mentioned this pull request Jul 11, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xenhancementNew feature or requestkit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0