Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): pass attrs and props to client-only components - #5668

Merged
pi0 merged 3 commits into
mainfrom
fix/client-only-attrs
Jun 30, 2022
Merged

fix(nuxt): pass attrs and props to client-only components#5668
pi0 merged 3 commits into
mainfrom
fix/client-only-attrs

Conversation

@danielroe

@danielroedanielroe commented Jun 30, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Currently props for a client-only component (e.g. ~/components/SomeComp.client.vue) aren't getting passed properly, because the Vue 2 signature was being used.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Jun 30, 2022
@danielroe
danielroe requested a review from pi0June 30, 2022 10:40
@danielroedanielroe self-assigned this Jun 30, 2022
@netlify

netlifyBot commented Jun 30, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit7992505
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62bd7dafbcf521000803ecb4

@netlify

netlifyBot commented Jun 30, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit68e1ee1
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62bd7e1d3e62c1000871d654

@danielroedanielroe changed the title fix(nuxt): pass attrs directly to client-only and display component namefix(nuxt): pass attrs/props to client-only componentsJun 30, 2022
@pi0pi0 changed the title fix(nuxt): pass attrs/props to client-only componentsfix(nuxt): pass attrs and props to client-only componentsJun 30, 2022
pi0
pi0 approved these changes Jun 30, 2022
View reviewed changes
@pi0
pi0 merged commit fe508f5 into mainJun 30, 2022
@pi0
pi0 deleted the fix/client-only-attrs branch June 30, 2022 14:08
@pi0pi0 mentioned this pull request Jul 11, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0