Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat(nuxt): prerender all pages by default - #5709

Merged
pi0 merged 3 commits into
mainfrom
feat/pages-prerender
Jul 7, 2022
Merged

feat(nuxt): prerender all pages by default#5709
pi0 merged 3 commits into
mainfrom
feat/pages-prerender

Conversation

@danielroe

@danielroedanielroe commented Jul 4, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#13945

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR adds all non-dynamic routes to the prerenderer by default, as we can't always rely on the crawler to fetch every page.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added enhancement New feature or request pages 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Jul 4, 2022
@danielroe
danielroe requested a review from pi0July 4, 2022 10:07
@danielroedanielroe self-assigned this Jul 4, 2022
@netlify

netlifyBot commented Jul 4, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit05733d8
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62c6ba755ac0c90009282f56

@danielroe
danielroe marked this pull request as draft July 4, 2022 10:16
pi0
pi0 reviewed Jul 4, 2022
View reviewed changes
Comment threadpackages/nuxt/src/pages/module.ts Outdated
pi0
pi0 reviewed Jul 4, 2022
View reviewed changes
Comment threadpackages/nuxt/src/pages/module.ts Outdated
pi0
pi0 reviewed Jul 4, 2022
View reviewed changes
Comment threadpackages/nuxt/src/pages/module.ts Outdated
pi0
pi0 reviewed Jul 4, 2022
View reviewed changes
Comment threadpackages/nuxt/src/pages/module.ts Outdated
@danielroe
danielroe marked this pull request as ready for review July 4, 2022 10:39
pi0
pi0 reviewed Jul 6, 2022
View reviewed changes
Comment threadpackages/nuxt/src/pages/module.ts
@danielroe
danielroeforce-pushed the feat/pages-prerender branch from 43c28aa to 6bc8b01CompareJuly 7, 2022 10:49
@danielroe
danielroe requested a review from pi0July 7, 2022 11:13
pi0
pi0 approved these changes Jul 7, 2022
View reviewed changes
@pi0
pi0 merged commit 271262e into mainJul 7, 2022
@pi0
pi0 deleted the feat/pages-prerender branch July 7, 2022 15:07
@pi0pi0 mentioned this pull request Jul 11, 2022
Merged
@TahulTahul mentioned this pull request Jan 19, 2023
Closed
@pi0pi0 mentioned this pull request Jul 11, 2022
Merged
7 tasks
@johannschopplichjohannschopplich mentioned this pull request Jan 19, 2023
Closed
danielroe added a commit to nuxt-modules/ionic that referenced this pull request Aug 17, 2022
@danielroe
fix: remove prerendering workaround
3b18f8f
now present in nuxt itself: nuxt/framework#5709
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xenhancementNew feature or request🍰 p2-nice-to-havePriority 2: nothing is broken but it's worth addressingpages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Yarn generate not generating pages for components on the pages directory

2 participants

@danielroe@pi0