Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): update useFetch key warning to include any function or blob - #5710

Merged
pi0 merged 2 commits into
mainfrom
fix/blob-key
Jul 6, 2022
Merged

fix(nuxt): update useFetch key warning to include any function or blob#5710
pi0 merged 2 commits into
mainfrom
fix/blob-key

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14257

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This slightly extends the warning for useFetch options to include any function passed to it, or also any Blob. (Though ohash will also throw an error if a Blob is passed.)

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added dx 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Jul 4, 2022
@danielroe
danielroe requested a review from pi0July 4, 2022 10:57
@danielroedanielroe self-assigned this Jul 4, 2022
@netlify

netlifyBot commented Jul 4, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commitc575461
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62c5dded2a85040008a3d918
😎 Deploy Previewhttps://deploy-preview-5710--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

pi0
pi0 approved these changes Jul 6, 2022
Comment threadpackages/nuxt/src/app/composables/fetch.ts Outdated
@pi0
pi0 merged commit f09d1d8 into mainJul 6, 2022
@pi0
pi0 deleted the fix/blob-key branch July 6, 2022 19:09
@pi0pi0 mentioned this pull request Jul 11, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xdx🍰 p2-nice-to-havePriority 2: nothing is broken but it's worth addressing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

call useFecth with Blob as body got error

2 participants

@danielroe@pi0