Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

perf(nuxt): transform #imports to improve tree-shaking - #5763

Merged
pi0 merged 8 commits into
mainfrom
feat/unimport-virtual-module
Jul 21, 2022
Merged

perf(nuxt): transform #imports to improve tree-shaking#5763
pi0 merged 8 commits into
mainfrom
feat/unimport-virtual-module

Conversation

@antfu

@antfuantfu commented Jul 7, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Jul 7, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit1b65b1e
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62d25813606f770008fde5c8

@pi0

pi0 commented Jul 7, 2022

Copy link
Copy Markdown
Member

Can you please check the failing test?

@antfu
antfu marked this pull request as draft July 7, 2022 09:02
@antfu

antfu commented Jul 7, 2022

Copy link
Copy Markdown
MemberAuthor

Yes, I am working on it, converted to draft for now.

@antfu
antfuforce-pushed the feat/unimport-virtual-module branch from 51ef602 to c00531fCompareJuly 7, 2022 09:29
@antfu
antfu marked this pull request as ready for review July 7, 2022 09:34
@antfu
antfu marked this pull request as draft July 7, 2022 09:55
@antfu
antfu marked this pull request as ready for review July 15, 2022 08:50
Comment threadpackages/nuxt/src/auto-imports/module.ts Outdated
pi0
pi0 approved these changes Jul 21, 2022
@pi0pi0 changed the title perf: transform #imports to improve tree-shakingperf(nuxt): transform #imports to improve tree-shakingJul 21, 2022
@pi0
pi0 merged commit 1a86252 into mainJul 21, 2022
@pi0
pi0 deleted the feat/unimport-virtual-module branch July 21, 2022 14:27
@pi0pi0 mentioned this pull request Aug 5, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@antfu@pi0@danielroe