Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix: pin vue-router to 4.0 minor branch - #5767

Merged
pi0 merged 2 commits into
mainfrom
fix/vue-router-devtools
Jul 7, 2022
Merged

fix: pin vue-router to 4.0 minor branch#5767
pi0 merged 2 commits into
mainfrom
fix/vue-router-devtools

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

for example, nuxt-modules/sanity#458

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

this is a hotfix for current vue-router build that includes @vue/devtools-api in its node build (see test failure in #5712).

cc: @posva

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working upstream labels Jul 7, 2022
@danielroe
danielroe requested a review from pi0July 7, 2022 10:43
@danielroedanielroe self-assigned this Jul 7, 2022
@netlify

netlifyBot commented Jul 7, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commiteceb4dc
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62c6b8d1c9d5ed000934d4bc

pi0
pi0 approved these changes Jul 7, 2022
@pi0
pi0 merged commit 5e419e7 into mainJul 7, 2022
@pi0
pi0 deleted the fix/vue-router-devtools branch July 7, 2022 15:04
@pi0pi0 mentioned this pull request Jul 11, 2022
@danielroedanielroe mentioned this pull request Jul 13, 2022
7 tasks
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't workingupstream

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0