Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

docs(data-fetching): fix and simplify cookie proxy example - #5770

Merged
pi0 merged 3 commits into
nuxt:mainfrom
mod7ex:patch-2
Aug 15, 2022
Merged

docs(data-fetching): fix and simplify cookie proxy example#5770
pi0 merged 3 commits into
nuxt:mainfrom
mod7ex:patch-2

Conversation

@mod7ex

Copy link
Copy Markdown
Contributor

cookies have this shape ==> Set-Cookie: <cookie-name>=<cookie-value>; Domain=<domain-value>; Secure;

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

cookies have this shape ==> `Set-Cookie: <cookie-name>=<cookie-value>; Domain=<domain-value>; Secure; `
@netlify

netlifyBot commented Jul 7, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit2d2b1ca
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62fa5d93abb2c7000856c265
😎 Deploy Previewhttps://deploy-preview-5770--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0pi0 changed the title cookies value-keys have a '; ' separatordocs: fix cookie parsing example in data-fetchingJul 7, 2022
Comment threaddocs/content/2.guide/2.features/5.data-fetching.md Outdated
@mod7ex
mod7ex requested a review from pi0July 7, 2022 18:06
pi0
pi0 approved these changes Aug 15, 2022

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR. I've finally decided to keep example simple using split only. for loop can be tweaked for more advanced usage such as filtering cookie by name to proxy.

@pi0pi0 changed the title docs: fix cookie parsing example in data-fetchingdocs(data-fetching): fix and simplify cookie proxy exampleAug 15, 2022
@pi0
pi0 merged commit e2745f6 into nuxt:mainAug 15, 2022
@pi0pi0 mentioned this pull request Aug 26, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mod7ex@pi0@danielroe