Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): don't return stub function from tree-shaken composables - #5786

Merged
pi0 merged 1 commit into
mainfrom
fix/composable-shake
Jul 8, 2022
Merged

fix(nuxt): don't return stub function from tree-shaken composables#5786
pi0 merged 1 commit into
mainfrom
fix/composable-shake

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Fixes a bug introduced in composable tree-shaking regexp. Also implemented in #5750 but if that's pending we should merge this hotfix sooner.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added the bug Something isn't working label Jul 8, 2022
@danielroe
danielroe requested a review from pi0July 8, 2022 12:24
@danielroedanielroe self-assigned this Jul 8, 2022
@netlify

netlifyBot commented Jul 8, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit92349b2
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62c821f3510ab40008addedf

@danielroedanielroe changed the title fix: tree-shake fixfix(nuxt): don't return stub function from tree-shaken composablesJul 8, 2022
pi0
pi0 approved these changes Jul 8, 2022
@pi0
pi0 merged commit b045b71 into mainJul 8, 2022
@pi0
pi0 deleted the fix/composable-shake branch July 8, 2022 12:42
@pi0pi0 mentioned this pull request Jul 11, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0