Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

refactor(nuxt): add import protection to nitro config - #5847

Merged
pi0 merged 3 commits into
mainfrom
refactor/import-config
Jul 12, 2022
Merged

refactor(nuxt): add import protection to nitro config#5847
pi0 merged 3 commits into
mainfrom
refactor/import-config

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

nuxt/content#1346 (comment)

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

While investigating nuxt/content#1346 (comment) (resolved with nitrojs/nitro#335), I think it doesn't make sense to add this in a hook when we can add it directly. Additional plus is that users get the plugin in nitro:config hook.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe
danielroe requested a review from pi0July 12, 2022 09:12
@danielroedanielroe self-assigned this Jul 12, 2022
@netlify

netlifyBot commented Jul 12, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitb62f1fe
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62cd3b01b5af8b00093109c7

@netlify

netlifyBot commented Jul 12, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commita0bda70
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62cd40e10f710300099dcce6

pi0
pi0 approved these changes Jul 12, 2022
@pi0
pi0 merged commit 1840b96 into mainJul 12, 2022
@pi0
pi0 deleted the refactor/import-config branch July 12, 2022 10:55
@pi0pi0 mentioned this pull request Jul 12, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0