Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): warn about legacy and invalid plugins - #5857

Merged
pi0 merged 9 commits into
mainfrom
fix/support-second-arg
Jul 12, 2022
Merged

fix(nuxt): warn about legacy and invalid plugins#5857
pi0 merged 9 commits into
mainfrom
fix/support-second-arg

Conversation

@danielroe

@danielroedanielroe commented Jul 12, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Following #5630, plugins which take a second argument for inject will silently fail. This at least adds a warning if they are being used. Example: https://github.com/moritzsternemann/vue-plausible/blob/main/src/nuxt-plugin.ts (hotfix PR).

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added the bug Something isn't working label Jul 12, 2022
@danielroe
danielroe requested a review from pi0July 12, 2022 14:22
@danielroedanielroe self-assigned this Jul 12, 2022
@netlify

netlifyBot commented Jul 12, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitd8c939c
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62cda9b46264050009ac97a7

pi0
pi0 approved these changes Jul 12, 2022
View reviewed changes
DamianGlowala
DamianGlowala reviewed Jul 12, 2022
View reviewed changes
Comment threadpackages/nuxt/src/app/nuxt.ts Outdated
@pi0pi0 changed the title fix(nuxt): pass provide as second argument for legacy pluginsfix(nuxt): skip legacy plugins with warningJul 12, 2022
@pi0pi0 changed the title fix(nuxt): skip legacy plugins with warningfix(nuxt): warn about legacy and invalid pluginsJul 12, 2022
@pi0
pi0 merged commit 1ced224 into mainJul 12, 2022
@pi0
pi0 deleted the fix/support-second-arg branch July 12, 2022 17:06
@pi0pi0 mentioned this pull request Jul 12, 2022
Merged
@kevinmarreckevinmarrec mentioned this pull request Jul 15, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@DamianGlowalaDamianGlowalaDamianGlowala left review comments
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielroe@pi0@DamianGlowala