Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

docs(runtime-config): clarify how environment variables are loaded - #5916

Merged
pi0 merged 7 commits into
nuxt:mainfrom
ennioVisco:patch-1
Jul 21, 2022
Merged

docs(runtime-config): clarify how environment variables are loaded#5916
pi0 merged 7 commits into
nuxt:mainfrom
ennioVisco:patch-1

Conversation

@ennioVisco

@ennioViscoennioVisco commented Jul 15, 2022

Copy link
Copy Markdown
Contributor

This change tries to clarify some approximate usage of the word runtime in explaining how the runtimeConfig API works.

🔗 Linked issue

It relates to issue nuxt/nuxt#14323, and, to discussion #5024.

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)

📚 Description

In particular:

  • clarifies what happens at runtime, and what at compile/build time
  • clarifies the purpose of dotenv (remarking that it also works in SSG)

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@ennioVisco
Clarified how environment variables are loaded
afe6e30
This change tries to clarify some approximate usage of the word runtime in explaining how the runtimeConfig API works.
@netlify

netlifyBot commented Jul 15, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commitfb28119
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62d9174ed6637d00093508c8
😎 Deploy Previewhttps://deploy-preview-5916--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

pi0
pi0 reviewed Jul 17, 2022
View reviewed changes
Comment threaddocs/content/2.guide/2.features/10.runtime-config.md Outdated
pi0
pi0 reviewed Jul 17, 2022
View reviewed changes
Comment threaddocs/content/2.guide/2.features/10.runtime-config.md Outdated
@pi0pi0 changed the title docs: Clarified how environment variables are loadeddocs(runtime-config): clarify how environment variables are loadedJul 17, 2022
@pi0
pi0 requested a review from danielroeJuly 17, 2022 14:21
danielroe
danielroe reviewed Jul 19, 2022
View reviewed changes
Comment threaddocs/content/2.guide/2.features/10.runtime-config.md Outdated
Comment threaddocs/content/2.guide/2.features/10.runtime-config.md Outdated
Comment threaddocs/content/2.guide/2.features/10.runtime-config.md Outdated
Comment threaddocs/content/2.guide/2.features/10.runtime-config.md Outdated
@danielroedanielroe added the documentation Improvements or additions to documentation label Jul 19, 2022
pi0
pi0 reviewed Jul 21, 2022
View reviewed changes
Comment threaddocs/content/2.guide/2.features/10.runtime-config.md Outdated
pi0
pi0 approved these changes Jul 21, 2022
View reviewed changes

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0
pi0 merged commit 2e794e7 into nuxt:mainJul 21, 2022
@pi0pi0 mentioned this pull request Aug 5, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@pi0pi0pi0 approved these changes
@danielroedanielroedanielroe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.xdocumentationImprovements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ennioVisco@pi0@danielroe