Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(kit): only call viteExtendConfig callback once if possible - #5929
Merged
Conversation
✅ Deploy Preview for nuxt3-docs canceled.
|
pi0
reviewed
Jul 15, 2022
Uh oh!
There was an error while loading. Please reload this page.
pi0
approved these changes
Jul 15, 2022
pi0
left a comment
Member
There was a problem hiding this comment.
LGTM as workaround. To discuss later about possible behavior changes for client+server mode.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
There's an outstanding issue with kit RC 5 that may break plugins that rely on being shared between client + server vite configs. (see unocss/unocss#1276 for an upstream hotfix). This PR ensures that if client/server flags aren't set, we will call the function only once.
📝 Checklist