Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): lazy load and tree-shake error templates - #5930

Merged
pi0 merged 7 commits into
mainfrom
perf/exclude-dev-error
Jul 15, 2022
Merged

fix(nuxt): lazy load and tree-shake error templates#5930
pi0 merged 7 commits into
mainfrom
perf/exclude-dev-error

Conversation

@danielroe

@danielroedanielroe commented Jul 15, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Currently error-dev is being bundled and not tree-shaken. This change uses a dynamic import for dev errors which allows vite to tree-shake it out of the final build.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added the 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage label Jul 15, 2022
@danielroe
danielroe requested a review from pi0July 15, 2022 21:05
@danielroedanielroe self-assigned this Jul 15, 2022
@netlify

netlifyBot commented Jul 15, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit1a1a368
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62d1e5f6395be8000838439d

pi0
pi0 reviewed Jul 15, 2022
View reviewed changes
Comment threadpackages/nuxt/src/app/components/nuxt-error-page.vue Outdated
pi0
pi0 reviewed Jul 15, 2022
View reviewed changes
Comment threadpackages/nuxt/src/app/components/nuxt-error-page.vue Outdated
kevinmarrec
kevinmarrec suggested changes Jul 15, 2022
View reviewed changes
Comment threadpackages/nuxt/src/app/components/nuxt-error-page.vue Outdated
@pi0@kevinmarrec
Update packages/nuxt/src/app/components/nuxt-error-page.vue
1a1a368
Co-authored-by: Kevin Marrec <kevin@marrec.io>
@pi0
pi0 requested a review from kevinmarrecJuly 15, 2022 22:11
@pi0pi0 changed the title fix(nuxt): tree-shake dev error page from bundlefix(nuxt): lazy load and tree-shake error templatesJul 15, 2022
pi0
pi0 approved these changes Jul 15, 2022
View reviewed changes
@pi0
pi0 merged commit dce07e5 into mainJul 15, 2022
@pi0
pi0 deleted the perf/exclude-dev-error branch July 15, 2022 22:15
@pi0pi0 mentioned this pull request Jul 15, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@pi0pi0pi0 approved these changes
@kevinmarreckevinmarreckevinmarrec approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.x🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielroe@pi0@kevinmarrec