Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(vite): unset build.watch options for production build - #5958

Merged
pi0 merged 1 commit into
mainfrom
fix/vite-watch
Jul 17, 2022
Merged

fix(vite): unset build.watch options for production build#5958
pi0 merged 1 commit into
mainfrom
fix/vite-watch

Conversation

@pi0

@pi0pi0 commented Jul 17, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

Resolvesnuxt/nuxt#14320

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

A regression was introduced in rc.5 with #5632 by adding build.watch key. The change likely only unrevealed an issue in vite. When this key exists for production, the server build promise succeeds but no output is generated! Removing watch key from production seems to solve this issue. This PR also refactors config placement to the shared one for more readability.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Jul 17, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit4e5a592
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62d423686abbf3000915d482

@pi0
pi0 merged commit 0839e93 into mainJul 17, 2022
@pi0
pi0 deleted the fix/vite-watch branch July 17, 2022 15:10
@pi0

pi0 commented Jul 17, 2022

Copy link
Copy Markdown
MemberAuthor

We likely need to investigate it sometime later or add an output checker for server.mjs. Vite failed build was completely silent!

@pi0pi0 mentioned this pull request Jul 17, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RC.5] Rollup error: Could not load .nuxt/dist/server/server.mjs

2 participants

@pi0@danielroe