Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt)!: change statusCode type to number for error page template - #6010

Merged
pi0 merged 1 commit into
mainfrom
fix/error-code-number
Jul 20, 2022
Merged

fix(nuxt)!: change statusCode type to number for error page template#6010
pi0 merged 1 commit into
mainfrom
fix/error-code-number

Conversation

@danielroe

@danielroedanielroe commented Jul 20, 2022

Copy link
Copy Markdown
Member

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We are currently providing errorCode as string, which is counter intuitive. I think it should probably be a number instead. However, this is a breaking change if people are checking it directly.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working dx 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Jul 20, 2022
@danielroe
danielroe requested a review from pi0July 20, 2022 11:00
@danielroedanielroe self-assigned this Jul 20, 2022
@netlify

netlifyBot commented Jul 20, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit0440025
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62d7e0557ffeee0008743c94
😎 Deploy Previewhttps://deploy-preview-6010--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0

pi0 commented Jul 20, 2022

Copy link
Copy Markdown
Member

Maybe merge this all together with #4539?

@danielroe

danielroe commented Jul 20, 2022

Copy link
Copy Markdown
MemberAuthor

Do you want to do that rather than merge this immediately?

@pi0pi0 changed the title fix(nuxt)!: provide error code as numberfix(nuxt)!: change statusCode type to number for error page templateJul 20, 2022
@pi0
pi0 merged commit 92269dd into mainJul 20, 2022
@pi0
pi0 deleted the fix/error-code-number branch July 20, 2022 17:00
@pi0pi0 mentioned this pull request Aug 5, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pi0pi0Awaiting requested review from pi0

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't workingdx🍰 p2-nice-to-havePriority 2: nothing is broken but it's worth addressing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0