Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat(vite): check types with vue-tsc - #6012

Merged
pi0 merged 2 commits into
mainfrom
fix/typecheck
Jul 20, 2022
Merged

feat(vite): check types with vue-tsc#6012
pi0 merged 2 commits into
mainfrom
fix/typecheck

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14336

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This uses the new vueTsc option of vite typechecker plugin which enables checking vue files 🙌

... and tells users they need to install dependencies for this to work.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working vite 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Jul 20, 2022
@danielroe
danielroe requested a review from pi0July 20, 2022 11:57
@danielroedanielroe self-assigned this Jul 20, 2022
@netlify

netlifyBot commented Jul 20, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit64b46bd
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62d7edc5d1e587000a6873b8
😎 Deploy Previewhttps://deploy-preview-6012--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0pi0 changed the title fix(vite): check types with vue-tscfeat(vite): check types with vue-tscJul 20, 2022
pi0
pi0 approved these changes Jul 20, 2022
@pi0
pi0 merged commit edbe4fe into mainJul 20, 2022
@pi0
pi0 deleted the fix/typecheck branch July 20, 2022 15:15
@pi0pi0 mentioned this pull request Aug 5, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usagevite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

typeCheck: true does nothing

2 participants

@danielroe@pi0