Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(pages): ignore expression delimiters within quotes - #6033

Merged
pi0 merged 3 commits into
mainfrom
fix/nested-quotes
Jul 21, 2022
Merged

fix(pages): ignore expression delimiters within quotes#6033
pi0 merged 3 commits into
mainfrom
fix/nested-quotes

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14312

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR fixes an oversight in the original code, which followed nesting within quotes.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working pages ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Jul 21, 2022
@danielroe
danielroe requested a review from pi0July 21, 2022 12:25
@danielroedanielroe self-assigned this Jul 21, 2022
@netlify

netlifyBot commented Jul 21, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commite6ece4e
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62d958b7debcb2000851495e

Comment threadpackages/nuxt/src/pages/macros.ts Outdated
pi0
pi0 approved these changes Jul 21, 2022
@pi0
pi0 merged commit 8f7b9f9 into mainJul 21, 2022
@pi0
pi0 deleted the fix/nested-quotes branch July 21, 2022 13:49
@pi0pi0 mentioned this pull request Aug 5, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working❗ p4-importantPriority 4: bugs that violate documented behavior, or significantly impact perfpages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DefinePageMeta formatting error when converting to const meta

2 participants

@danielroe@pi0