Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(kit): resolve aliases in plugin src - #6037

Merged
pi0 merged 1 commit into
mainfrom
fix/normalize-plugin-paths
Jul 21, 2022
Merged

fix(kit): resolve aliases in plugin src#6037
pi0 merged 1 commit into
mainfrom
fix/normalize-plugin-paths

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14299

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The test in

returnBoolean(app?.plugins.find(i=>i.src===id)||app.middleware.find(m=>m.path===id))
relies on an absolute path. It probably makes sense to resolve plugin paths to absolute when normalizing though, and this resolves the other issue too.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working kit 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Jul 21, 2022
@danielroe
danielroe requested a review from pi0July 21, 2022 13:55
@danielroedanielroe self-assigned this Jul 21, 2022
@netlify

netlifyBot commented Jul 21, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit86923dc
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62d95ae056933a000899810c

pi0
pi0 approved these changes Jul 21, 2022
@pi0
pi0 merged commit 4d80c43 into mainJul 21, 2022
@pi0
pi0 deleted the fix/normalize-plugin-paths branch July 21, 2022 14:05
@pi0pi0 mentioned this pull request Aug 5, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't workingkit🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Async plugins not working correctly when registered via nuxt.config

2 participants

@danielroe@pi0