Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(vite): ignore baseurl when pruning manifest - #6063

Merged
pi0 merged 5 commits into
mainfrom
fix/manifest-base-url
Jul 25, 2022
Merged

fix(vite): ignore baseurl when pruning manifest#6063
pi0 merged 5 commits into
mainfrom
fix/manifest-base-url

Conversation

@danielroe

@danielroedanielroe commented Jul 22, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14377

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We shouldn't prefix RE with baseURL - only the buildAssetsDir should be removed from these filenames.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working vite 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Jul 22, 2022
@danielroe
danielroe requested a review from pi0July 22, 2022 11:11
@danielroedanielroe self-assigned this Jul 22, 2022
@netlify

netlifyBot commented Jul 22, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit64e01a9
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62dadf5e2f9ee40008188c32

@atinux

atinux commented Jul 22, 2022

Copy link
Copy Markdown
Member

Cannot we add a test case for the fix issue to avoid any future regression?

pi0
pi0 reviewed Jul 22, 2022
View reviewed changes
Comment threadpackages/vite/src/server.ts Outdated
pi0
pi0 approved these changes Jul 25, 2022
View reviewed changes
@pi0
pi0 merged commit c7d072c into mainJul 25, 2022
@pi0
pi0 deleted the fix/manifest-base-url branch July 25, 2022 09:52
@pi0pi0 mentioned this pull request Aug 5, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usagevite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Duplicated path prefix with static rendering and RC6

3 participants

@danielroe@atinux@pi0