Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(vite): allow overriding client hmr options - #6082

Merged
pi0 merged 4 commits into
mainfrom
fix/vite-user-hmr
Jul 25, 2022
Merged

fix(vite): allow overriding client hmr options#6082
pi0 merged 4 commits into
mainfrom
fix/vite-user-hmr

Conversation

@danielroe

@danielroedanielroe commented Jul 23, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14371

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This fixes a regression in upgrade to Vite 3. Our client config should only contain what we want to override the basic user config, and HMR is probably in the list of things that should be configurable.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working vite 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Jul 23, 2022
@danielroe
danielroe requested a review from pi0July 23, 2022 10:06
@danielroedanielroe self-assigned this Jul 23, 2022
@netlify

netlifyBot commented Jul 23, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitb64868e
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62de8a8b4c648900091a3e5f

pi0
pi0 reviewed Jul 25, 2022
View reviewed changes
Comment threadpackages/vite/src/server.ts Outdated
@danielroe
danielroe requested a review from pi0July 25, 2022 11:52
pi0
pi0 reviewed Jul 25, 2022
View reviewed changes
Comment threadpackages/vite/src/client.ts Outdated
@pi0pi0 changed the title fix(vite): move hmr settings to defaults, not overridesfix(vite): allow overriding client hmr optionsJul 25, 2022
pi0
pi0 approved these changes Jul 25, 2022
View reviewed changes
@pi0
pi0 merged commit 8298cf2 into mainJul 25, 2022
@pi0
pi0 deleted the fix/vite-user-hmr branch July 25, 2022 12:29
@pi0pi0 mentioned this pull request Aug 5, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usagevite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Vite HMR user settings not being respected

2 participants

@danielroe@pi0