Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): don't ignore components dirs with same prefix - #6116

Merged
pi0 merged 1 commit into
mainfrom
fix/ignored-components-dirs
Jul 25, 2022
Merged

fix(nuxt): don't ignore components dirs with same prefix#6116
pi0 merged 1 commit into
mainfrom
fix/ignored-components-dirs

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We were only testing for prefix, so ~/components/test would mean ~/components/tests would be silently ignored.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Jul 25, 2022
@danielroe
danielroe requested a review from pi0July 25, 2022 10:07
@danielroedanielroe self-assigned this Jul 25, 2022
@netlify

netlifyBot commented Jul 25, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit5324ab3
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62de6b46ca27730008739750

pi0
pi0 approved these changes Jul 25, 2022
@pi0
pi0 merged commit 6c125bc into mainJul 25, 2022
@pi0
pi0 deleted the fix/ignored-components-dirs branch July 25, 2022 10:13
@pi0pi0 mentioned this pull request Aug 5, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0