Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat(nuxt, schema): add <NoScript> component and noscript typings - #6139

Merged
pi0 merged 5 commits into
nuxt:mainfrom
vis97c:main
Jul 26, 2022
Merged

feat(nuxt, schema): add <NoScript> component and noscript typings#6139
pi0 merged 5 commits into
nuxt:mainfrom
vis97c:main

Conversation

@vis97c

@vis97cvis97c commented Jul 26, 2022

Copy link
Copy Markdown
Contributor

🔗 Linked issue

nuxt/nuxt#13848

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Following @danielroe & @pi0 recommendations I'm adding typings for the meta feature noscript

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Jul 26, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitfb3a7b4
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62dfee41d0c1b400091fb04e

danielroe
danielroe reviewed Jul 26, 2022
View reviewed changes
Comment threaddocs/content/3.api/1.composables/use-head.md Outdated
danielroe
danielroe reviewed Jul 26, 2022
View reviewed changes
Comment threadpackages/schema/src/config/_app.ts Outdated
danielroe
danielroe reviewed Jul 26, 2022
View reviewed changes
Comment threaddocs/content/3.api/1.composables/use-head.md Outdated
@danielroedanielroe changed the title docs: add noscript typings & documentationfeat: add noscript typings & documentationJul 26, 2022
@danielroedanielroe changed the title feat: add noscript typings & documentationfeat(nuxt, schema): add noscript typings, component and documentationJul 26, 2022
@pi0@danielroe
Update packages/schema/src/config/_app.ts
3bd1c42
Co-authored-by: Daniel Roe <daniel@roe.dev>
pi0
pi0 reviewed Jul 26, 2022
View reviewed changes
Comment threadpackages/nuxt/src/head/runtime/components.ts Outdated
@pi0pi0 changed the title feat(nuxt, schema): add noscript typings, component and documentationfeat(nuxt, schema): add <NoScript> component and noscript typingsJul 26, 2022
pi0
pi0 approved these changes Jul 26, 2022
View reviewed changes

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pi0
pi0 merged commit 5d023a8 into nuxt:mainJul 26, 2022
@danielroedanielroe mentioned this pull request Jul 26, 2022
Merged
7 tasks
@vis97c

vis97c commented Jul 26, 2022

Copy link
Copy Markdown
ContributorAuthor

Oh wow didn't expected you to do the fixes. It was already late so i just wanted to send the pr and fix it later. Thanks @pi0@danielroe

@pi0pi0 mentioned this pull request Aug 5, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@danielroedanielroedanielroe left review comments
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vis97c@pi0@danielroe