Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): add emits.error declaration to NuxtErrorBoundary component - #6141

Merged
pi0 merged 1 commit into
nuxt:mainfrom
hecateball:main
Jul 26, 2022
Merged

fix(nuxt): add emits.error declaration to NuxtErrorBoundary component#6141
pi0 merged 1 commit into
nuxt:mainfrom
hecateball:main

Conversation

@hecateball

Copy link
Copy Markdown
Contributor

🔗 Linked issue

nuxt/nuxt#14402 Get warning when v-on:error event handler is set to NuxtErrorBoundary

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

add emits.error declaration to NuxtErrorBoundary to prevent prevent getting warning message.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Jul 26, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit0162a9c
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62df8e6549d73b0008196fca
😎 Deploy Previewhttps://deploy-preview-6141--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Comment threadpackages/nuxt/src/app/components/nuxt-error-boundary.ts

@danielroedanielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch and solution 👌

pi0
pi0 approved these changes Jul 26, 2022
@pi0
pi0 merged commit e08a493 into nuxt:mainJul 26, 2022
@pi0pi0 mentioned this pull request Aug 5, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@hecateball@pi0@danielroe