Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

test: wrap components with <div> - #6192

Merged
pi0 merged 1 commit into
mainfrom
test/fix-globals
Jul 29, 2022
Merged

test: wrap components with <div>#6192
pi0 merged 1 commit into
mainfrom
test/fix-globals

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Small issue - we're getting a hydration error because these components need to be wrapped in a <div>.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe
danielroe requested a review from pi0July 27, 2022 22:10
@danielroedanielroe self-assigned this Jul 27, 2022
@netlify

netlifyBot commented Jul 27, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit9a6c5f6
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62e1b7bc09c642000a5f1f73
😎 Deploy Previewhttps://deploy-preview-6192--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0
pi0 merged commit 90d1825 into mainJul 29, 2022
@pi0
pi0 deleted the test/fix-globals branch July 29, 2022 09:41
@pi0pi0 mentioned this pull request Aug 5, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@danielroe@atinux@pi0