Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): don't call renderMeta if it is not defined - #6201

Merged
atinux merged 2 commits into
mainfrom
fix/render-meta
Jul 28, 2022
Merged

fix(nuxt): don't call renderMeta if it is not defined#6201
atinux merged 2 commits into
mainfrom
fix/render-meta

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

.renderMeta is not defined in SPA mode. I think we should also serialize app.head for use in this context, but that can be a follow-up PR.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Jul 28, 2022
@danielroe
danielroe requested a review from pi0July 28, 2022 09:42
@danielroedanielroe self-assigned this Jul 28, 2022
@netlify

netlifyBot commented Jul 28, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit31bf5d4
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62e272c9ba733b000a3497b8

@jkneepkens

Copy link
Copy Markdown

This bug completely destroyed our dev and build step, as we have ssr set on false in the config. Hopefully it can be merged and deployed quickly!

@danielroe
danielroe requested review from antfu and atinuxJuly 28, 2022 12:24
@atinux
atinux merged commit 748b063 into mainJul 28, 2022
@atinux
atinux deleted the fix/render-meta branch July 28, 2022 13:11
@pi0pi0 mentioned this pull request Aug 5, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@danielroe@jkneepkens@atinux