Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat(test-utils): add mockFn and mockLogger utils - #6235

Merged
pi0 merged 15 commits into
nuxt:mainfrom
ricardogobbosouza:test-utils-add-mocks
Sep 5, 2022
Merged

feat(test-utils): add mockFn and mockLogger utils#6235
pi0 merged 15 commits into
nuxt:mainfrom
ricardogobbosouza:test-utils-add-mocks

Conversation

@ricardogobbosouza

@ricardogobbosouzaricardogobbosouza commented Jul 29, 2022

Copy link
Copy Markdown
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Add mockLogger used in module testing

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Jul 29, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commita72b345
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6315b0ef2937a20008145577
😎 Deploy Previewhttps://deploy-preview-6235--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ricardogobbosouzaricardogobbosouza changed the title feat(test-utils): add mocksfeat(test-utils): add mockLoggerJul 29, 2022
pi0
pi0 reviewed Jul 29, 2022
View reviewed changes
Comment threadpackages/test-utils/src/mocks.ts Outdated
@ricardogobbosouzaricardogobbosouza changed the title feat(test-utils): add mockLoggerfeat(test-utils): add mocksJul 29, 2022
@pi0pi0 changed the title feat(test-utils): add mocksfeat(test-utils): add mockFn and mockLogger utilsAug 23, 2022
danielroe
danielroe reviewed Aug 25, 2022
View reviewed changes
Comment threadpackages/test-utils/src/mock.ts Outdated
pi0
pi0 reviewed Sep 5, 2022
View reviewed changes
Comment threaddocs/content/2.guide/6.going-further/7.testing.md Outdated
pi0
pi0 approved these changes Sep 5, 2022
View reviewed changes

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice initiative! Thanks (i didn't well tested this addition with latest changes. please feel free to make pr if have any issues)

@pi0
pi0 merged commit b31405f into nuxt:mainSep 5, 2022
@ricardogobbosouza

ricardogobbosouza commented Sep 5, 2022

Copy link
Copy Markdown
ContributorAuthor

Nice @pi0

This was referenced Sep 9, 2022
Merged
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@danielroedanielroedanielroe left review comments
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ricardogobbosouza@pi0@danielroe