feat(nuxt): add `fetchpriority` attribute and literal typings for meta components by sanjaiyan-dev · Pull Request #6251 · nuxt/framework

sanjaiyan-dev · 2022-07-29T19:41:15Z

Added fetchpriority attr in script and link component.

netlify · 2022-07-29T19:41:20Z

✅ Deploy Preview for nuxt3-docs canceled.

Name	Link
🔨 Latest commit	`9ca4154`
🔍 Latest deploy log	https://app.netlify.com/sites/nuxt3-docs/deploys/62e91246fca631000893a819

DamianGlowala · 2022-07-30T10:12:23Z

Shall we narrow down the accepted values for the fetchpriority attribute, as per https://wicg.github.io/priority-hints/#definitions?

sanjaiyan-dev · 2022-07-30T17:32:22Z

Shall we narrow down the accepted values for the fetchpriority attribute, as per https://wicg.github.io/priority-hints/#definitions?

💪🏽

sanjaiyan-dev · 2022-07-30T17:59:16Z

Sorry, I have copied the code from #6262 for adding typings for reference-policy attribute 🙇🏽

DamianGlowala · 2022-07-30T19:10:26Z

Great enhancement! I have closed #6262 in favor of your changes. There are two remarks that I've got:

Why is boolean accepted for crossorigin? Some counterexamples:
- Remove crossorigin from boolean attribute maltsev/htmlnano#79
- Booleanish behaviour of attributes like crossorigin not supported vue-meta#447
x-ua-compatible appears to be missing in httpEquiv, as per https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta#attr-http-equiv.

sanjaiyan-dev · 2022-07-31T08:28:58Z

Great enhancement! I have closed #6262 in favor of your changes. There are two remarks that I've got:
Why is boolean accepted for crossorigin? Some counterexamples:
Remove crossorigin from boolean attribute posthtml/htmlnano#79
Booleanish behaviour of attributes like crossorigin not supported vue-meta#447
x-ua-compatible appears to be missing in httpEquiv, as per https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta#attr-http-equiv.

Boolean type is equivalent to crossorigin="" which is shorthand way of writing crossorigin="anonymous" so this makes typing code easier ,

<imgcrossorigin/>

is easier than

<imgcrossorigin="" />

And even browser parse the html with crossorigin attr empty string as <link crossorigin /> (not sure)
I am not 100% sure about it :
so, do we need to add boolean type too ?

sanjaiyan-dev · 2022-07-31T08:37:40Z

Great enhancement! I have closed #6262 in favor of your changes. There are two remarks that I've got:
Why is boolean accepted for crossorigin? Some counterexamples:
Remove crossorigin from boolean attribute posthtml/htmlnano#79
Booleanish behaviour of attributes like crossorigin not supported vue-meta#447
x-ua-compatible appears to be missing in httpEquiv, as per https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta#attr-http-equiv.
Boolean type is equivalent to crossorigin="" which is shorthand way of writing crossorigin="anonymous" so this makes typing code easier ,
<img crossorigin />
is easier than
<img />
And even browser parse the html with crossorigin attr empty string as <link crossorigin /> (not sure) I am not 100% sure about it : so, do we need to add boolean type too ?

I am sorry if I am wrong :(

DamianGlowala · 2022-07-31T08:51:09Z

All I am thinking is whether the following would be preferable:

crossorigin: String as PropType<CrossOrigin>

Let's wait for others to express their thoughts, not sure which way to go :)

sanjaiyan-dev · 2022-07-31T10:22:40Z

All I am thinking is whether the following would be preferable:
crossorigin: String as PropType<CrossOrigin>
Let's wait for others to express their thoughts, not sure which way to go :)

Ok 🙌

sanjaiyan-dev · 2022-08-01T04:43:32Z

typeLinkRelationship=|"alternate"|"author"|"canonical"|"dns-prefetch"|"help"|"icon"|"license"|"manifest"|"me"|"modulepreload"|"next"|"pingback"|"preconnect"|"prefetch"|"preload"|"prerender"|"prev"|"search"|"stylesheet"|String;

Added types for <link /> tag with String constructor to accept any future value while preserving intellisense 😄

danielroe

Love the direction of this PR. ❤️ Would you revert the various style/lint changes that have been made by your IDE?

sanjaiyan-dev · 2022-08-01T12:28:09Z

Love the direction of this PR. ❤️ Would you revert the various style/lint changes that have been made by your IDE?

Yeah sure 🙌

sanjaiyan-dev · 2022-08-01T15:59:35Z

Made suggested change (not sure) 😄

danielroe

Really nice enhancement - thanks! ❤️

pi0

Thanks!

sanjaiyan-dev · 2022-08-02T12:09:35Z

Thanks!

My pleasure 💪🙌

sanjaiyan-dev added 3 commits July 30, 2022 00:41

Addming meta-theme color
cdfd24f

Adding fetchpriority attr
39f7238

Remove one old change :)
9528bf2

sanjaiyan-dev changed the title ~~Sanjaiyan-fetchpiritory-attr~~Adding fetchpriority attrJul 29, 2022

danielroe approved these changes Jul 29, 2022
View reviewed changes

danielroe changed the title ~~Adding fetchpriority attr~~feat(nuxt): add fetchpriority attr to <Script> and <Link>Jul 29, 2022

DamianGlowala mentioned this pull request Jul 30, 2022
feat(nuxt): add literal type to referrerpolicy attr of <Script> and <Link>#6262
Closed
7 tasks

DamianGlowala suggested changes Jul 30, 2022
View reviewed changes

Comment threadpackages/nuxt/src/head/runtime/components.ts Outdated
Comment threadpackages/nuxt/src/head/runtime/components.ts Outdated

Improving typings :)
e10a17d

sanjaiyan-dev changed the title ~~feat(nuxt): add fetchpriority attr to <Script> and <Link>~~feat(nuxt): add fetchpriority attr to <Script> and <Link> and minor improvements in types :)Jul 30, 2022

sanjaiyan-dev changed the title ~~feat(nuxt): add fetchpriority attr to <Script> and <Link> and minor improvements in types :)~~feat(nuxt): Add fetchpriority attr to <Script> and <Link> and minor improvements in types :)Jul 30, 2022

Adding end line
0b6c6e3

Adding x-ua-compatible value in http-quiv attribute
d310d68

Formatting and adding types for link tag.
cb867f0

Adding types for target attribute
03bf690

DamianGlowala reviewed Aug 1, 2022
View reviewed changes

Comment threadpackages/nuxt/src/head/runtime/components.ts Outdated

sanjaiyan-dev added 2 commits August 1, 2022 12:45

Typo error
cb32cf1

...
67e4c51

danielroe suggested changes Aug 1, 2022
View reviewed changes

suggested changes 1
70265f4

pi0 requested a review from danielroe August 2, 2022 11:44

pi0 changed the title ~~feat(nuxt): Add fetchpriority attr to <Script> and <Link> and minor improvements in types :)~~feat(nuxt): add fetchpriority attribute to the <Script> and <Link> componentsAug 2, 2022

pi0and others added 6 commits August 2, 2022 13:46

Merge branch 'main' into sanjaiyan-fetchpiritory-attr
6313abf

style: lint
8a6d8b2

fix: type and lint
eb03d11

update types exports
0b596d0

fix: export types singly and don't use constructor as a type
b5abdb4

fix: rebase conflict
a0f09dc

danielroe reviewed Aug 2, 2022
View reviewed changes

Comment threadpackages/nuxt/src/head/runtime/types.ts Outdated

danielroe approved these changes Aug 2, 2022
View reviewed changes

danielroe changed the title ~~feat(nuxt): add fetchpriority attribute to the <Script> and <Link> components~~feat(nuxt): add fetchpriority attribute and literal typings for meta componentsAug 2, 2022

feat: preserve auto-completion
9ca4154

pi0 approved these changes Aug 2, 2022
View reviewed changes

pi0 merged commit 94d0c08 into nuxt:mainAug 2, 2022

pi0 mentioned this pull request Aug 5, 2022
v3.0.0-rc.7 #6375
Merged

This was referenced Aug 5, 2022
fix(schema): cleanup meta tags and deduplicate charset/viewport #6378
Merged
add typings for MetaObjectnuxt/nuxt#14498
Closed

danielroe added the 3.x label Jan 19, 2023

Uh oh!

Uh oh!

Conversation

sanjaiyan-dev commented Jul 29, 2022

Uh oh!

netlifyBot commented Jul 29, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for nuxt3-docs canceled.

Uh oh!

DamianGlowala commented Jul 30, 2022

Uh oh!

Uh oh!

Uh oh!

sanjaiyan-dev commented Jul 30, 2022

Uh oh!

sanjaiyan-dev commented Jul 30, 2022

Uh oh!

DamianGlowala commented Jul 30, 2022

Uh oh!

sanjaiyan-dev commented Jul 31, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sanjaiyan-dev commented Jul 31, 2022

Uh oh!

DamianGlowala commented Jul 31, 2022

Uh oh!

sanjaiyan-dev commented Jul 31, 2022

Uh oh!

sanjaiyan-dev commented Aug 1, 2022

Uh oh!

Uh oh!

danielroe left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sanjaiyan-dev commented Aug 1, 2022

Uh oh!

sanjaiyan-dev commented Aug 1, 2022

Uh oh!

Uh oh!

danielroe left a comment

Choose a reason for hiding this comment

Uh oh!

pi0 left a comment

Choose a reason for hiding this comment

Uh oh!

sanjaiyan-dev commented Aug 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

netlifyBot commented Jul 29, 2022•
edited
Loading

sanjaiyan-dev commented Jul 31, 2022•
edited
Loading

danielroe left a comment •
edited
Loading