Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): do not allow catchalls to have child routes - #6257

Merged
pi0 merged 2 commits into
mainfrom
fix/catchall-children
Aug 1, 2022
Merged

fix(nuxt): do not allow catchalls to have child routes#6257
pi0 merged 2 commits into
mainfrom
fix/catchall-children

Conversation

@danielroe

@danielroedanielroe commented Jul 29, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

failing case shown in updated test

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR checks that a potential parent is not a catchall before giving it children, which can lead to very unexpected behaviour when present.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working pages 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Jul 29, 2022
@danielroe
danielroe requested a review from pi0July 29, 2022 22:42
@danielroedanielroe self-assigned this Jul 29, 2022
@netlify

netlifyBot commented Jul 29, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit444da03
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62e4626696a2180008d0e976
😎 Deploy Previewhttps://deploy-preview-6257--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Eckhardt-D

Eckhardt-D commented Jul 30, 2022

Copy link
Copy Markdown
Contributor

@danielroe Not much of a race. Was it? 💯 Great seeing this fix after experiencing it live. Well done and thank you

@danielroe

danielroe commented Jul 30, 2022

Copy link
Copy Markdown
MemberAuthor

@Eckhardt-D I'm so sorry, this annoyed me so much I couldn't wait. 🙈

pi0
pi0 approved these changes Aug 1, 2022
View reviewed changes
@pi0
pi0 merged commit 96cfe01 into mainAug 1, 2022
@pi0
pi0 deleted the fix/catchall-children branch August 1, 2022 07:51
@pi0pi0 mentioned this pull request Aug 5, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usagepages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielroe@Eckhardt-D@pi0