Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): generate 200.html and 404.html spa fallback files - #6308

Merged
pi0 merged 1 commit into
mainfrom
fix/spa-fallback2
Aug 2, 2022
Merged

fix(nuxt): generate 200.html and 404.html spa fallback files#6308
pi0 merged 1 commit into
mainfrom
fix/spa-fallback2

Conversation

@pi0

@pi0pi0 commented Aug 2, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

As a regression of nitrojs/nitro#166, we were generating dist/200/index.html instead of dist/200.html for spa fallbacks. This makes expected output.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Aug 2, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commitef7e150
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62e9529fbc13cb00094f4216

@pi0pi0 changed the title fix(nuxt): properly generate 200.html and 404.html fallback filesfix(nuxt): generate 200.html and 404.html spa fallback filesAug 2, 2022
@pi0
pi0 merged commit 000d81d into mainAug 2, 2022
@pi0
pi0 deleted the fix/spa-fallback2 branch August 2, 2022 16:45
@TheAlexLichter

Copy link
Copy Markdown
Member

This still works only for ssr: false, right?

@pi0

pi0 commented Aug 2, 2022

Copy link
Copy Markdown
MemberAuthor

@manniL Yes 👍 We need nitro route rules as discussed to to selectively set spa mode on these routes when generating with ssr enabled.

@pi0pi0 mentioned this pull request Aug 5, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pi0@TheAlexLichter@danielroe