Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): extract component to provide route - #6325

Merged
pi0 merged 2 commits into
mainfrom
fix/suspense-with-keys
Aug 3, 2022
Merged

fix(nuxt): extract component to provide route#6325
pi0 merged 2 commits into
mainfrom
fix/suspense-with-keys

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14475

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This fixes a regression where we always rerender route components.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working pages ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Aug 3, 2022
@danielroe
danielroe requested a review from pi0August 3, 2022 10:10
@danielroedanielroe self-assigned this Aug 3, 2022
@netlify

netlifyBot commented Aug 3, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit7774546
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62ea4dd9075f6a0009f4ba68

@danielroedanielroe changed the title fix(nuxt): provide route inlinefix(nuxt): extract component to provide routeAug 3, 2022
pi0
pi0 approved these changes Aug 3, 2022

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally trying behavior of last commit seems 👍🏼

@pi0
pi0 merged commit f75d0df into mainAug 3, 2022
@pi0
pi0 deleted the fix/suspense-with-keys branch August 3, 2022 10:38
@pi0pi0 mentioned this pull request Aug 5, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working❗ p4-importantPriority 4: bugs that violate documented behavior, or significantly impact perfpages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

edge version is triggering re-renders on nested pages

2 participants

@danielroe@pi0