Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

docs(api): add missing hooks and environment column - #6329

Merged
pi0 merged 5 commits into
mainfrom
docs/hooks
Aug 4, 2022
Merged

docs(api): add missing hooks and environment column#6329
pi0 merged 5 commits into
mainfrom
docs/hooks

Conversation

@atinux

@atinuxatinux commented Aug 3, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

Resolvesnuxt/nuxt#14488

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

I would love a second pair of eyes to make sure I am not mistaken.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@atinux
atinux requested review from danielroe and pi0August 3, 2022 10:56
@netlify

netlifyBot commented Aug 3, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit41b4f71
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62eba9669798fc000891e5d1
😎 Deploy Previewhttps://deploy-preview-6329--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@atinuxatinux mentioned this pull request Aug 3, 2022
Closed
7 tasks
pi0
pi0 reviewed Aug 3, 2022
View reviewed changes
Comment threaddocs/content/3.api/4.advanced/1.hooks.md Outdated
danielroe
danielroe reviewed Aug 3, 2022
View reviewed changes
Comment threaddocs/content/3.api/4.advanced/1.hooks.md Outdated
danielroe
danielroe reviewed Aug 3, 2022
View reviewed changes
Comment threaddocs/content/3.api/4.advanced/1.hooks.md Outdated
danielroe
danielroe reviewed Aug 3, 2022
View reviewed changes
Comment threaddocs/content/3.api/4.advanced/1.hooks.md Outdated
pi0and others added 2 commits August 3, 2022 13:24
@pi0@danielroe
Update docs/content/3.api/4.advanced/1.hooks.md
f7c860e
Co-authored-by: Daniel Roe <daniel@roe.dev>
@pi0@danielroe
Update docs/content/3.api/4.advanced/1.hooks.md
f225018
Co-authored-by: Daniel Roe <daniel@roe.dev>
DamianGlowala
DamianGlowala reviewed Aug 3, 2022
View reviewed changes
Comment threaddocs/content/3.api/4.advanced/1.hooks.md Outdated
@pi0@DamianGlowala
Update docs/content/3.api/4.advanced/1.hooks.md
f9c5bbb
Co-authored-by: Damian Głowala <48835293+DamianGlowala@users.noreply.github.com>
@pi0pi0 changed the title docs(api): Add environment column on hooksdocs(api): add environment column on hooksAug 4, 2022
@pi0pi0 changed the title docs(api): add environment column on hooksdocs(api): add missing hooks and environment columnAug 4, 2022
@pi0
pi0 merged commit 2abf4a5 into mainAug 4, 2022
@pi0
pi0 deleted the docs/hooks branch August 4, 2022 11:12
@pi0pi0 mentioned this pull request Aug 5, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers
@pi0pi0pi0 left review comments
@danielroedanielroedanielroe left review comments
@DamianGlowalaDamianGlowalaDamianGlowala left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

app:beforeMount hook is actually a client-side lifecycle hook

4 participants

@atinux@pi0@danielroe@DamianGlowala