Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(vite): use url for entry on windows - #6355

Merged
pi0 merged 4 commits into
mainfrom
fix/windows-vite-entry
Aug 4, 2022
Merged

fix(vite): use url for entry on windows#6355
pi0 merged 4 commits into
mainfrom
fix/windows-vite-entry

Conversation

@danielroe

@danielroedanielroe commented Aug 4, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14370

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This resolves the entry path via a file URL on Windows to skip vite trying to resolve it as an import from nuxt3 directly.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working vite windows ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Aug 4, 2022
@danielroe
danielroe requested a review from pi0August 4, 2022 12:08
@danielroedanielroe self-assigned this Aug 4, 2022
@netlify

netlifyBot commented Aug 4, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit3ddc24b
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62ebd2a79b007900081f84cf

@danielroe
danielroe marked this pull request as draft August 4, 2022 12:09
pi0
pi0 reviewed Aug 4, 2022
View reviewed changes
Comment threadpackages/vite/src/vite.ts Outdated
@danielroe
danielroe marked this pull request as ready for review August 4, 2022 14:07
@danielroe
danielroe requested a review from pi0August 4, 2022 14:19
pi0
pi0 reviewed Aug 4, 2022
View reviewed changes
Comment threadpackages/vite/src/dev-bundler.ts
pi0
pi0 approved these changes Aug 4, 2022
View reviewed changes

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@pi0
pi0 merged commit 463c15e into mainAug 4, 2022
@pi0
pi0 deleted the fix/windows-vite-entry branch August 4, 2022 15:24
@pi0pi0 mentioned this pull request Aug 5, 2022
Merged
@danielroedanielroe mentioned this pull request Aug 8, 2022
Closed
@pi0pi0 mentioned this pull request Aug 11, 2022
Merged
7 tasks
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't working❗ p4-importantPriority 4: bugs that violate documented behavior, or significantly impact perfvitewindows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing "./dist/app/entry" export in "nuxt3" package

2 participants

@danielroe@pi0