Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): use payload error state as source of truth - #6389

Merged
pi0 merged 5 commits into
mainfrom
fix/error-state
Aug 8, 2022
Merged

fix(nuxt): use payload error state as source of truth#6389
pi0 merged 5 commits into
mainfrom
fix/error-state

Conversation

@danielroe

@danielroedanielroe commented Aug 5, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#14494

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This resolves an inconsistency caused by the fact that if there was no error on server render, we completely ignore payload.error on client. Instead, we can use this as the source of truth instead of duplicating the error into the state as well.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Aug 5, 2022
@danielroe
danielroe requested a review from pi0August 5, 2022 16:18
@danielroedanielroe self-assigned this Aug 5, 2022
@netlify

netlifyBot commented Aug 5, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit2d2852e
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62f0dfd5feecc60008a3fc5c

pi0
pi0 reviewed Aug 5, 2022
View reviewed changes
Comment threadpackages/nuxt/src/app/composables/error.ts Outdated
@danielroe
danielroe requested a review from pi0August 8, 2022 10:33
pi0
pi0 reviewed Aug 8, 2022
View reviewed changes
Comment threadpackages/nuxt/src/app/nuxt.ts
pi0
pi0 approved these changes Aug 8, 2022
View reviewed changes

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

@pi0
pi0 merged commit 46f36a4 into mainAug 8, 2022
@pi0
pi0 deleted the fix/error-state branch August 8, 2022 14:33
@pi0pi0 mentioned this pull request Aug 9, 2022
Merged
@danielroedanielroe mentioned this pull request Aug 30, 2022
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Client-only plugins swallow errors with ssr: true

2 participants

@danielroe@pi0