Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): add viteServerDynamicImports as experimental flag - #6433

Merged
pi0 merged 8 commits into
mainfrom
fix/experimental-dynamic
Aug 8, 2022
Merged

fix(nuxt): add viteServerDynamicImports as experimental flag#6433
pi0 merged 8 commits into
mainfrom
fix/experimental-dynamic

Conversation

@pi0

@pi0pi0 commented Aug 8, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

nuxt/nuxt#14525

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR disables change introduced in #5506 (rc.5 and rc.6) and move it behind experimental.viteServerDynamicImports flag until we can identify related issues. To enable:

import{defineNuxtConfig}from'nuxt'exportdefaultdefineNuxtConfig({experimental: {viteServerDynamicImports: true}})

Todo:

  • Test webpack behavior (works fine with dynamic chunks! seems vite-only issue therefore updating exeprimental flag)

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Aug 8, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit827e07a
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62f10ed12ed453000884d809

@pi0
pi0 marked this pull request as ready for review August 8, 2022 13:15
@pi0pi0 changed the title fix(nuxt): add serverDynamicImports as experimental flagfix(nuxt): add viteServerDynamicImports as experimental flagAug 8, 2022
@pi0pi0 changed the title fix(nuxt): add viteServerDynamicImports as experimental flagfix(nuxt): add viteServerDynamicImports as experimental flagAug 8, 2022
@pi0
pi0 merged commit ee36ddf into mainAug 8, 2022
@pi0
pi0 deleted the fix/experimental-dynamic branch August 8, 2022 13:25
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pi0@danielroe