Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(vite): add module type to vite node entry - #6448

Merged
pi0 merged 1 commit into
mainfrom
fix/vite-node-entry
Aug 9, 2022
Merged

fix(vite): add module type to vite node entry#6448
pi0 merged 1 commit into
mainfrom
fix/vite-node-entry

Conversation

@danielroe

@danielroedanielroe commented Aug 8, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

@vite/client is a module. Without this we get Uncaught SyntaxError: import declarations may only appear at top level of a module. Evidently missed from vue-bundle-renderer upgrade.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added the bug Something isn't working label Aug 8, 2022
@danielroe
danielroe requested a review from pi0August 8, 2022 21:48
@danielroedanielroe self-assigned this Aug 8, 2022
@netlify

netlifyBot commented Aug 8, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit5c5fb10
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62f184cc5e3c1100086e045f

pi0
pi0 approved these changes Aug 9, 2022
@pi0
pi0 merged commit ae388e7 into mainAug 9, 2022
@pi0
pi0 deleted the fix/vite-node-entry branch August 9, 2022 07:59
@pi0pi0 mentioned this pull request Aug 9, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0