Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

docs(schema): grammar, punctuation and typo fixes - #6469

Merged
pi0 merged 32 commits into
nuxt:mainfrom
timursaurus:schema-fixes
Aug 11, 2022
Merged

docs(schema): grammar, punctuation and typo fixes#6469
pi0 merged 32 commits into
nuxt:mainfrom
timursaurus:schema-fixes

Conversation

@timursaurus

@timursaurustimursaurus commented Aug 9, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Aug 9, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit4bc8954
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62f38de49a0f5800084122e7

DamianGlowala
DamianGlowala suggested changes Aug 10, 2022
View reviewed changes
Comment threadpackages/schema/src/config/_app.ts Outdated
Comment threadpackages/schema/src/config/_app.ts Outdated
Comment threadpackages/schema/src/config/_app.ts Outdated
Comment threadpackages/schema/src/config/_common.ts Outdated
Comment threadpackages/schema/src/config/experimental.ts Outdated
Comment threadpackages/schema/src/config/nitro.ts Outdated
Comment threadpackages/schema/src/config/render.ts Outdated
Comment threadpackages/schema/src/config/render.ts Outdated
Comment threadpackages/schema/src/config/router.ts Outdated
Comment threadpackages/schema/src/config/webpack.ts Outdated
timursaurusand others added 9 commits August 10, 2022 13:00
@timursaurus@DamianGlowala
Update packages/schema/src/config/_app.ts
4400684
Co-authored-by: Damian Głowala <48835293+DamianGlowala@users.noreply.github.com>
@timursaurus@DamianGlowala
Update packages/schema/src/config/_common.ts
d9b395e
Co-authored-by: Damian Głowala <48835293+DamianGlowala@users.noreply.github.com>
@timursaurus@DamianGlowala
Update packages/schema/src/config/router.ts
c8e55cd
Co-authored-by: Damian Głowala <48835293+DamianGlowala@users.noreply.github.com>
@timursaurus@DamianGlowala
Update packages/schema/src/config/_app.ts
b107f28
Co-authored-by: Damian Głowala <48835293+DamianGlowala@users.noreply.github.com>
@timursaurus@DamianGlowala
Update packages/schema/src/config/webpack.ts
ac6cafb
Co-authored-by: Damian Głowala <48835293+DamianGlowala@users.noreply.github.com>
@timursaurus
Update router.ts
12b35d6
@timursaurus@DamianGlowala
Update packages/schema/src/config/nitro.ts
6914bdc
Co-authored-by: Damian Głowala <48835293+DamianGlowala@users.noreply.github.com>
@timursaurus@DamianGlowala
Update packages/schema/src/config/render.ts
33ef65c
Co-authored-by: Damian Głowala <48835293+DamianGlowala@users.noreply.github.com>
@timursaurus@DamianGlowala
Update packages/schema/src/config/experimental.ts
86167b3
Co-authored-by: Damian Głowala <48835293+DamianGlowala@users.noreply.github.com>
timursaurusand others added 2 commits August 10, 2022 13:42
@timursaurus@DamianGlowala
Update packages/schema/src/config/render.ts
c611393
Co-authored-by: Damian Głowala <48835293+DamianGlowala@users.noreply.github.com>
@timursaurus@DamianGlowala
Update packages/schema/src/config/_app.ts
6877235
Co-authored-by: Damian Głowala <48835293+DamianGlowala@users.noreply.github.com>
danielroe
danielroe reviewed Aug 10, 2022
View reviewed changes
Comment threadpackages/schema/src/config/webpack.ts Outdated
danielroe
danielroe approved these changes Aug 10, 2022
View reviewed changes

@danielroedanielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of painstaking work - thank you! ❤️

pi0
pi0 approved these changes Aug 11, 2022
View reviewed changes

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks <3

@pi0
pi0 merged commit e55938f into nuxt:mainAug 11, 2022
@pi0pi0 mentioned this pull request Aug 11, 2022
Merged
@timursaurus
timursaurus deleted the schema-fixes branch August 24, 2022 10:28
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers
@DamianGlowalaDamianGlowalaDamianGlowala requested changes
@pi0pi0pi0 approved these changes
@danielroedanielroedanielroe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@timursaurus@pi0@danielroe@DamianGlowala