Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): ensure asyncdata handler has nuxt app context - #6472

Merged
pi0 merged 3 commits into
mainfrom
fix/data-context
Aug 9, 2022
Merged

fix(nuxt): ensure asyncdata handler has nuxt app context#6472
pi0 merged 3 commits into
mainfrom
fix/data-context

Conversation

@danielroe

@danielroedanielroe commented Aug 9, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

A regression of #6441 - we were not passing context to asyncdata calls.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Aug 9, 2022
@danielroe
danielroe requested a review from pi0August 9, 2022 21:38
@danielroedanielroe self-assigned this Aug 9, 2022
@netlify

netlifyBot commented Aug 9, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit19cc72c
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62f2d57acee4fe0008a44b7b

pi0
pi0 approved these changes Aug 9, 2022
View reviewed changes
@pi0pi0 changed the title fix(nuxt): provide nuxt app to asyncdata handlerfix(nuxt): immediately call asyncData handlerAug 9, 2022
@danielroedanielroe changed the title fix(nuxt): immediately call asyncData handlerfix(nuxt): ensure asyncdata handler has nuxt app contextAug 9, 2022
@pi0
pi0 merged commit 5232c1b into mainAug 9, 2022
@pi0
pi0 deleted the fix/data-context branch August 9, 2022 21:48
@pi0pi0 mentioned this pull request Aug 11, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't working❗ p4-importantPriority 4: bugs that violate documented behavior, or significantly impact perf

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0