Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

refactor(nuxt)!: remove null handling for titleTemplate - #6487

Merged
pi0 merged 1 commit into
mainfrom
fix/title-template
Aug 10, 2022
Merged

refactor(nuxt)!: remove null handling for titleTemplate#6487
pi0 merged 1 commit into
mainfrom
fix/title-template

Conversation

@danielroe

@danielroedanielroe commented Aug 10, 2022•
edited
Loading

Copy link
Copy Markdown
Member

🔗 Linked issue

follow on from #6296

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

It seems we have a little leftover titleTemplate handling. I think we don't need this - was there a reason we left it in?

👉 Migration

If you were previously using titleTemplate: null you should update this to titleTemplate: ''.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Aug 10, 2022
@danielroe
danielroe requested a review from pi0August 10, 2022 14:47
@danielroedanielroe self-assigned this Aug 10, 2022
@netlify

netlifyBot commented Aug 10, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commita5177bf
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62f3c4f5d4cf250009c13561

@pi0

pi0 commented Aug 10, 2022

Copy link
Copy Markdown
Member

Have you checked notes in #6296 (comment)? I belive it was to avoid a breaking change for null handling

@danielroe

danielroe commented Aug 10, 2022

Copy link
Copy Markdown
MemberAuthor

Yes, I spotted that. I think an acceptable change for RC7 if you agree, but we'll need to mention in release notes.

@pi0

pi0 commented Aug 10, 2022

Copy link
Copy Markdown
Member

Do you mind to update PR as breaking change for migration guide?

@danielroedanielroe changed the title fix(nuxt): remove rest of titleTemplate handlingfix(nuxt)!: remove rest of titleTemplate handlingAug 10, 2022
pi0
pi0 approved these changes Aug 10, 2022
View reviewed changes
@pi0pi0 changed the title fix(nuxt)!: remove rest of titleTemplate handlingrefactor(nuxt)!: remove null handling for titleTemplateAug 10, 2022
@pi0
pi0 merged commit 408feba into mainAug 10, 2022
@pi0
pi0 deleted the fix/title-template branch August 10, 2022 15:46
@pi0pi0 mentioned this pull request Aug 11, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't working🍰 p2-nice-to-havePriority 2: nothing is broken but it's worth addressing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0