Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): log fatal errors as well as unhandled ones - #6488

Merged
pi0 merged 3 commits into
mainfrom
fix/fatal-logging
Aug 10, 2022
Merged

fix(nuxt): log fatal errors as well as unhandled ones#6488
pi0 merged 3 commits into
mainfrom
fix/fatal-logging

Conversation

@danielroe

@danielroedanielroe commented Aug 10, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

h3js/h3#162

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This logs fatal errors in addition to unhandled ones.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working nitro labels Aug 10, 2022
@danielroe
danielroe requested a review from pi0August 10, 2022 14:58
@danielroedanielroe self-assigned this Aug 10, 2022
@netlify

netlifyBot commented Aug 10, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit6d98255
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62f3cdf21309aa00081d72d0

pi0
pi0 reviewed Aug 10, 2022
View reviewed changes
Comment threadpackages/nuxt/src/core/runtime/nitro/error.ts Outdated
pi0
pi0 reviewed Aug 10, 2022
View reviewed changes
Comment threadpackages/nuxt/src/core/runtime/nitro/error.ts Outdated
pi0
pi0 approved these changes Aug 10, 2022
View reviewed changes
pi0
pi0 approved these changes Aug 10, 2022
View reviewed changes
@pi0
pi0 merged commit 5aa7288 into mainAug 10, 2022
@pi0
pi0 deleted the fix/fatal-logging branch August 10, 2022 15:47
@pi0pi0 mentioned this pull request Aug 11, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pi0pi0pi0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't workingnitro

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0