Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

docs: global style imports - #6490

Merged
pi0 merged 10 commits into
nuxt:mainfrom
AngeloSchulerPiletti:patch-1
Aug 14, 2022
Merged

docs: global style imports#6490
pi0 merged 10 commits into
nuxt:mainfrom
AngeloSchulerPiletti:patch-1

Conversation

@AngeloSchulerPiletti

@AngeloSchulerPilettiAngeloSchulerPiletti commented Aug 10, 2022

Copy link
Copy Markdown
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

It shows how can you import SCSS/SASS files (such as other preprocessors) to be used globally at your Nuxt components.

It took a while to figure out how to do it using Nuxt 3. Also, I noticed that there are other ones with the same doubt asking in forums.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

It shows how can you import SCSS/SASS files (such as other preprocessors) to be used globally at your Nuxt components.
Why did I create it?
It took a while to figure out how to do it using Nuxt 3. Also, I noticed that there are other ones with the same doubt asking in forums.
@netlify

netlifyBot commented Aug 10, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit8010d15
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62f8ef2f69b343000826e786
😎 Deploy Previewhttps://deploy-preview-6490--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0pi0 added the documentation Improvements or additions to documentation label Aug 11, 2022
@pi0pi0 mentioned this pull request Jan 19, 2023
4 tasks
@pi0

pi0 commented Aug 11, 2022

Copy link
Copy Markdown
Member

Thanks for PR @AngeloSchulerPiletti <3 I believe this feature deserves to be better supported but in the meantime, seems nice solution to be included in documentation. I made nuxt/nuxt#14545 to track improvements.

@pi0
pi0 requested review from antfu, atinux and danielroeAugust 11, 2022 21:35
@AngeloSchulerPiletti

Copy link
Copy Markdown
ContributorAuthor

Nice contribution @pi0! I totally agree with you

Comment threaddocs/content/2.guide/2.features/3.assets.md Outdated
Comment threaddocs/content/2.guide/2.features/3.assets.md Outdated
Comment threaddocs/content/2.guide/2.features/3.assets.md Outdated

@atinuxatinux left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I believe this is good to start and we can improve later on following #6536

@antfuantfu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chore: formatting

pi0
pi0 approved these changes Aug 14, 2022

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pi0
pi0 merged commit ff92446 into nuxt:mainAug 14, 2022
@pi0pi0 mentioned this pull request Aug 26, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xdocumentationImprovements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@AngeloSchulerPiletti@pi0@atinux@antfu@danielroe