Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

docs: change info to danger for pages root element - #6528

Merged
pi0 merged 1 commit into
nuxt:mainfrom
genu:docs/danger
Aug 11, 2022
Merged

docs: change info to danger for pages root element#6528
pi0 merged 1 commit into
nuxt:mainfrom
genu:docs/danger

Conversation

@genu

@genugenu commented Aug 11, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

nuxt/nuxt#13350

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

When < NuxtPage/> is a root element, it throws a Failed to execute 'insertBefore' on 'Node' error

There is a note in the docs that it is recommended to not to make it a root element, but I think this should be marked as a danger because it actually causes an error if you do.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Aug 11, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit0f42340
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62f548886e0f09000a745bd1

@genu
genu marked this pull request as ready for review August 11, 2022 18:20
pi0
pi0 approved these changes Aug 11, 2022
@pi0pi0 changed the title docs: change info to dangerdocs: change info to danger for pages root elementAug 11, 2022
@pi0
pi0 merged commit 1072140 into nuxt:mainAug 11, 2022
@pi0

pi0 commented Aug 11, 2022

Copy link
Copy Markdown
Member

Thanks

@pi0pi0 mentioned this pull request Aug 11, 2022
@genu
genu deleted the docs/danger branch August 11, 2022 23:08
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@genu@pi0@danielroe