Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(vite, nuxt): resolve relative to srcDir rather than rootDir - #6546

Merged
pi0 merged 4 commits into
mainfrom
fix/srcdir-fixes
Aug 12, 2022
Merged

fix(vite, nuxt): resolve relative to srcDir rather than rootDir#6546
pi0 merged 4 commits into
mainfrom
fix/srcdir-fixes

Conversation

@danielroe

@danielroedanielroe commented Aug 12, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

With a custom srcDir, various things were not working, including scanning of new components.

This also makes a couple of changes to vite-node, to match the non-vite node implementation where root is set to srcDir and not rootDir but would value @antfu's verdict on these.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working vite labels Aug 12, 2022
@danielroe
danielroe requested review from antfu and pi0August 12, 2022 08:49
@danielroedanielroe self-assigned this Aug 12, 2022
@netlify

netlifyBot commented Aug 12, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit1b32c94
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62f618d44c27700008a48b0a

antfu
antfu reviewed Aug 12, 2022
View reviewed changes
Comment threadpackages/vite/src/vite-node.ts
pi0
pi0 approved these changes Aug 12, 2022
View reviewed changes
danielroeand others added 2 commits August 12, 2022 09:58
@danielroe@antfu
Update packages/vite/src/vite-node.ts
e5edbe9
Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
@danielroe
fix: use srcDir
b3c8f0e
pi0
pi0 reviewed Aug 12, 2022
View reviewed changes
Comment threadpackages/vite/src/runtime/vite-node.mjs Outdated
@pi0pi0 changed the title fix(nuxt, vite): resolve relative to srcDir rather than rootDirfix(vite): resolve relative to srcDir rather than rootDirAug 12, 2022
@pi0pi0 changed the title fix(vite): resolve relative to srcDir rather than rootDirfix(vite, nuxt): resolve relative to srcDir rather than rootDirAug 12, 2022
@pi0
pi0 merged commit 70b024f into mainAug 12, 2022
@pi0
pi0 deleted the fix/srcdir-fixes branch August 12, 2022 09:11
@pi0pi0 mentioned this pull request Aug 12, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@pi0pi0pi0 approved these changes
@antfuantfuantfu left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@danielroedanielroe

Labels

3.xbugSomething isn't workingvite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielroe@pi0@antfu