Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): don't set asyncData to existing payload on CSR if initialCache is disabled - #6640

Merged
pi0 merged 2 commits into
mainfrom
fix/client-cache
Aug 15, 2022
Merged

fix(nuxt): don't set asyncData to existing payload on CSR if initialCache is disabled#6640
pi0 merged 2 commits into
mainfrom
fix/client-cache

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#13872

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We were ignoring initialCache setting if data was already present in payload. I've exempted us from respecting initialCache if we are hydrating. (In this case, server: false should be used rather than initialCache: false.)

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Aug 15, 2022
@danielroe
danielroe requested a review from pi0August 15, 2022 13:43
@danielroedanielroe self-assigned this Aug 15, 2022
@netlify

netlifyBot commented Aug 15, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit7075c9f
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62fa4dc1ec461900093d9da2

pi0
pi0 approved these changes Aug 15, 2022
@pi0
pi0 merged commit 33e7fc1 into mainAug 15, 2022
@pi0
pi0 deleted the fix/client-cache branch August 15, 2022 13:55
@pi0pi0 mentioned this pull request Aug 26, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

useLazyAsyncData ignores initialCache:false option

2 participants

@danielroe@pi0