Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

refactor(nuxt, kit): improve type strictness - #6685

Merged
pi0 merged 8 commits into
mainfrom
chore/ts-strict-take-3
Aug 22, 2022
Merged

refactor(nuxt, kit): improve type strictness#6685
pi0 merged 8 commits into
mainfrom
chore/ts-strict-take-3

Conversation

@antfu

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Aug 16, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit0512f10
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/63034e1982b95a000a789685
😎 Deploy Previewhttps://deploy-preview-6685--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@antfu
antfu marked this pull request as ready for review August 18, 2022 08:05
// Happens with CLI reloads
if (!nuxt) {
return null
return false

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context: This was to distinguish situations where isIgnoredcannot identify ignoring from when it detects file is actually ignored.

pi0
pi0 approved these changes Aug 22, 2022

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes. Thanks <3

@pi0pi0 changed the title chore(nuxt, kit): improve type strictnessrefactor(nuxt, kit): improve type strictnessAug 22, 2022
@pi0
pi0 merged commit e1e39b7 into mainAug 22, 2022
@pi0
pi0 deleted the chore/ts-strict-take-3 branch August 22, 2022 10:12
@pi0pi0 mentioned this pull request Aug 26, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@antfu@pi0@danielroe