Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): use vue-devtools-stub to mock @vue/devtools-api for both cjs + esm - #6713

Merged
pi0 merged 3 commits into
mainfrom
fix/devtools-api
Aug 17, 2022
Merged

fix(nuxt): use vue-devtools-stub to mock @vue/devtools-api for both cjs + esm#6713
pi0 merged 3 commits into
mainfrom
fix/devtools-api

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolvesnuxt/nuxt#13743

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

When @vue/devtools-api is imported in an ESM module (as in pinia), our cjs proxy doesn't work. Thanks to @pi0, we now have a standalone stub we can use that works in both ESM + CJS contexts.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working nitro labels Aug 17, 2022
@danielroe
danielroe requested a review from pi0August 17, 2022 13:28
@danielroedanielroe self-assigned this Aug 17, 2022
@netlify

netlifyBot commented Aug 17, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit71712ce
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62fcf839b2fa3500098102c1

Comment threadtest/fixtures/basic/pages/index.vue Outdated
pi0
pi0 approved these changes Aug 17, 2022
@pi0
pi0 merged commit 405629d into mainAug 17, 2022
@pi0
pi0 deleted the fix/devtools-api branch August 17, 2022 14:44
@pi0pi0 mentioned this pull request Aug 26, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't workingnitro

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'setupDevtoolsPlugin' is not exported by unenv

2 participants

@danielroe@pi0