Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

docs(api): add <NuxtWelcome /> component docs - #6745

Merged
pi0 merged 6 commits into
nuxt:mainfrom
umutiq:nuxt-welcome-doc
Aug 18, 2022
Merged

docs(api): add <NuxtWelcome /> component docs#6745
pi0 merged 6 commits into
nuxt:mainfrom
umutiq:nuxt-welcome-doc

Conversation

@umutiq

@umutiqumutiq commented Aug 18, 2022

Copy link
Copy Markdown
Contributor

🔗 Linked issue

resolvesnuxt/nuxt#14613

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Solves nuxt/nuxt#14613

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Aug 18, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commitf7f4a11
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/62fe44bb2ae04e00087ae695
😎 Deploy Previewhttps://deploy-preview-6745--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0pi0 changed the title docs: added <NuxtWelcome /> documentationdocs(api): add <NuxtWelcome /> component docsAug 18, 2022
Comment threaddocs/content/3.api/2.components/6-nuxt-welcome.md Outdated
Co-authored-by: Daniel Roe <daniel@roe.dev>
@pi0

pi0 commented Aug 18, 2022

Copy link
Copy Markdown
Member

Do you mind to add a ::ReadMore link to https://github.com/nuxt/ui?

@umutiq

Copy link
Copy Markdown
ContributorAuthor

@pi0 Since we didn't mention it's imported from @nuxt/ui, i think it's inapporpriate.

@danielroe

danielroe commented Aug 18, 2022

Copy link
Copy Markdown
Member

Maybe we should mention it then. I think it would be a good idea for people to know where (for example) to make PRs if they have improvements.

@danielroedanielroe added the documentation Improvements or additions to documentation label Aug 18, 2022
@umutiq

Copy link
Copy Markdown
ContributorAuthor

@danielroe I added alert and Readmore links to document. Can you check it?

Comment threaddocs/content/3.api/2.components/6-nuxt-welcome.md Outdated
pi0
pi0 approved these changes Aug 18, 2022

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks <3

Comment threaddocs/content/3.api/2.components/6-nuxt-welcome.md
@pi0
pi0 merged commit ee25a15 into nuxt:mainAug 18, 2022
@BD103

Copy link
Copy Markdown

Thank you!

@pi0pi0 mentioned this pull request Aug 26, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xdocumentationImprovements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document <NuxtWelcome />

5 participants

@umutiq@pi0@danielroe@BD103@DamianGlowala