Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): use deep assignment for app.config hmr - #6788

Merged
pi0 merged 4 commits into
mainfrom
fix/app-config-hmr
Aug 22, 2022
Merged

fix(nuxt): use deep assignment for app.config hmr#6788
pi0 merged 4 commits into
mainfrom
fix/app-config-hmr

Conversation

@pi0

@pi0pi0 commented Aug 19, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This fix allows using useAppConfig().theme to remain reactive with HMR support

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Aug 19, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commitd5b0196
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/630348cc332d280008821c16
😎 Deploy Previewhttps://deploy-preview-6788--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0
pi0force-pushed the fix/app-config-hmr branch from 01ba8ba to 1ed49f9CompareAugust 19, 2022 21:38
@pi0
pi0 marked this pull request as ready for review August 22, 2022 09:10
@pi0
pi0 merged commit 3b2b22e into mainAug 22, 2022
@pi0
pi0 deleted the fix/app-config-hmr branch August 22, 2022 09:14
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pi0@danielroe