Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

feat!(schema): enable external vue by default - #6868

Merged
pi0 merged 1 commit into
mainfrom
fix/enable-external-vue-by-default
Aug 23, 2022
Merged

feat!(schema): enable external vue by default#6868
pi0 merged 1 commit into
mainfrom
fix/enable-external-vue-by-default

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

nuxt/nuxt#13632

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This enables external vue by default on edge releases. Instead, it can be disabled by setting experimental.externalVue to false. Before RC, we can then remove the flag entirely.

I have tested on a few projects (small + large projects, no monorepo, a module's playground) with no issues, but some issues might be expected, particularly in complex projects with multiple vue component libraries. Feedback is particularly welcome. Please feel free to tag me in a new issue if you encounter any problems.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added the enhancement New feature or request label Aug 23, 2022
@danielroe
danielroe requested a review from pi0August 23, 2022 11:07
@danielroedanielroe self-assigned this Aug 23, 2022
@netlify

netlifyBot commented Aug 23, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

NameLink
🔨 Latest commit27c65c9
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6304b4e7b32225000831f9c5

pi0
pi0 approved these changes Aug 23, 2022
@pi0pi0 changed the title feat(schema): enable external vue by defaultfeat!(schema): enable external vue by defaultAug 23, 2022
@pi0
pi0 merged commit 51dc736 into mainAug 23, 2022
@pi0
pi0 deleted the fix/enable-external-vue-by-default branch August 23, 2022 11:35
@pi0pi0 mentioned this pull request Aug 26, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xenhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0