Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

fix(nuxt): lazy composables shouldn't block setup in ssr: false - #6901

Merged
pi0 merged 1 commit into
mainfrom
fix/lazy-spa
Aug 24, 2022
Merged

fix(nuxt): lazy composables shouldn't block setup in ssr: false#6901
pi0 merged 1 commit into
mainfrom
fix/lazy-spa

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Looks like we weren't covering the condition of ssr: false & lazy: true. Reported in chat.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroedanielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Aug 24, 2022
@danielroe
danielroe requested a review from pi0August 24, 2022 12:43
@danielroedanielroe self-assigned this Aug 24, 2022
@netlify

netlifyBot commented Aug 24, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit5ccd397
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/63061d0e780c160008733e4d
😎 Deploy Previewhttps://deploy-preview-6901--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0

pi0 commented Aug 24, 2022

Copy link
Copy Markdown
Member

@danielroe Can you please kindly make a reproduction?

@danielroe

danielroe commented Aug 24, 2022

Copy link
Copy Markdown
MemberAuthor

pi0
pi0 approved these changes Aug 24, 2022
@pi0
pi0 merged commit 403e0e6 into mainAug 24, 2022
@pi0
pi0 deleted the fix/lazy-spa branch August 24, 2022 19:05
@pi0pi0 mentioned this pull request Aug 26, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.xbugSomething isn't working🔨 p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@pi0