Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.
/frameworkPublic archive

refactor: enable strict type checking everywhere - #6943

Merged
pi0 merged 9 commits into
mainfrom
chore/ts-strict-take-4
Aug 26, 2022
Merged

refactor: enable strict type checking everywhere#6943
pi0 merged 9 commits into
mainfrom
chore/ts-strict-take-4

Conversation

@antfu

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This is the final PR to enable TS strictness, by enabling strict at top-level tsconfig.json and removing all the tsconfig.json in sub packages.

Blocked by unjs/untyped#45

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Aug 25, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

NameLink
🔨 Latest commit088e529
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt3-docs/deploys/6308e0be23258b000bd6d378
😎 Deploy Previewhttps://deploy-preview-6943--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0

pi0 commented Aug 26, 2022

Copy link
Copy Markdown
Member

Released unjs/untyped#45 in 0.4.6. Update on main works but seems when we add type assertions, a regression happened to the loader. Still investigating to see what's going on. But two things we need to solve:

  • Regression to the loader
  • Probably a defineSchemaObject from untyped to remove the need for manual <InputObject> for $resolve typeing.

@pi0
pi0force-pushed the chore/ts-strict-take-4 branch from 279a9c7 to 51c72a2CompareAugust 26, 2022 13:04
@pi0

pi0 commented Aug 26, 2022

Copy link
Copy Markdown
Member

Schema is fine now. I will move new type to untyped and release in parallel. We have 41 new appear issues :D

image

@antfu
antfu marked this pull request as ready for review August 26, 2022 15:03
pi0
pi0 approved these changes Aug 26, 2022

@pi0pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

@pi0pi0 changed the title chore: improve type strictnessrefactor: enable strict type checking everywhereAug 26, 2022
@pi0
pi0 merged commit 9db2229 into mainAug 26, 2022
@pi0
pi0 deleted the chore/ts-strict-take-4 branch August 26, 2022 15:47
@pi0pi0 mentioned this pull request Sep 1, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@antfu@pi0@danielroe